Re: [PATCH] isdn/hisax: amd7930_fn: Remove unnecessary parentheses

From: David Miller
Date: Thu Oct 11 2018 - 01:29:23 EST


From: Nathan Chancellor <natechancellor@xxxxxxxxx>
Date: Mon, 8 Oct 2018 15:59:05 -0700

> Clang warns when multiple sets of parentheses are used for a single
> conditional statement.
>
> drivers/isdn/hisax/amd7930_fn.c:628:32: warning: equality comparison
> with extraneous parentheses [-Wparentheses-equality]
> if ((cs->dc.amd7930.ph_state == 8)) {
> ~~~~~~~~~~~~~~~~~~~~~~~~^~~~
> drivers/isdn/hisax/amd7930_fn.c:628:32: note: remove extraneous
> parentheses around the comparison to silence this warning
> if ((cs->dc.amd7930.ph_state == 8)) {
> ~ ^ ~
> drivers/isdn/hisax/amd7930_fn.c:628:32: note: use '=' to turn this
> equality comparison into an assignment
> if ((cs->dc.amd7930.ph_state == 8)) {
> ^~
> =
> 1 warning generated.
>
> Signed-off-by: Nathan Chancellor <natechancellor@xxxxxxxxx>

Applied.