Re: [RFC][PATCH 1/3] printk: keep kernel cont support always enabled

[Sergey Senozhatsky]

On (10/09/18 10:14), Petr Mladek wrote:
> Just to be sure. The original purpose was to get full information
> including the metadata and dictionary via extended console drivers,
> see commit 6fe29354befe4c46e ("printk: implement support for extended
> console drivers").

Right.

> IMHO, only the dictionary was really important but it was actually
> lost:
> 
>   static void cont_flush(void)
>   {
>   [...]
> 	log_store(cont.facility, cont.level, cont.flags, cont.ts_nsec,
> 		  NULL, 0, cont.buf, cont.len);
> 
> Nobody noticed because the only dictionary user is dev_printk()
> and dev_cont() is _not_ defined.

Right.

> As a result, I think that this change will rather improve things.
> Well, I wonder if we should write something of the above into
> the commit message. Either way:

The commit message probably can be improved, agreed.

> Reviewed-by: Petr Mladek <pmladek@xxxxxxxx>

Thanks.

	-ss