Re: [PATCH] tools/lib/traceevent, tools/perf: Move struct tep_handler definition in a local header file

From: Steven Rostedt
Date: Mon Oct 08 2018 - 15:54:46 EST


On Mon, 8 Oct 2018 14:32:24 -0300
Arnaldo Carvalho de Melo <acme@xxxxxxxxxx> wrote:

> Em Fri, Oct 05, 2018 at 12:28:46PM -0400, Steven Rostedt escreveu:
> > On Fri, 5 Oct 2018 12:22:25 -0400
> > Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:
> >
> > > +/**
> > > + * tep_get_first_event - returns the first event in the events array
> > > + * @tep: a handle to the tep_handle
> > > + *
> > > + * This returns pointer to the first element of the events array
> > > + * If @tep is NULL, NULL is returned.
> > > + */
> > > +struct tep_event_format *tep_get_first_event(struct tep_handle *tep)
> > > +{
> > > + if(tep && tep->events)
> > > + return tep->events[0];
> > > +
> > > + return NULL;
> > > +}
> > > +
> >
> > Hold off on pulling this in. This patch has some whitespace issues that
> > need to be cleaned up.
>
> Ah, that if( thing? ?I can fix it here, holler if there is more than
> that.

Well, here's a fixed up version anyway...

-- Steve