Re: [PATCH v2 net-next] inet: do not set backlog if listen fails

From: Yafang Shao
Date: Mon Oct 08 2018 - 10:59:00 EST


On Mon, Oct 8, 2018 at 10:48 PM Eric Dumazet <edumazet@xxxxxxxxxx> wrote:
>
> On Mon, Oct 8, 2018 at 3:47 AM Yafang Shao <laoar.shao@xxxxxxxxx> wrote:
> >
> >
> > Pls. correct me if I missed something.
> >
>
> You missed that this variable must be set before listener is setup.
> Same feedback than prior version really (when you trived to move
> around sk_ack_backlog clearing)
>
> You are changing inet_csk_listen_start() but this is wrong...

Got it.
Thank you.