Re: [PATCH v2] staging: erofs: add SPDX identifer

From: Greg Kroah-Hartman
Date: Mon Oct 08 2018 - 10:43:41 EST


On Mon, Oct 08, 2018 at 10:36:39PM +0800, Gao Xiang wrote:
> Hi Greg,
>
> On 2018/10/8 22:22, Greg Kroah-Hartman wrote:
> > Why delete that line?
> >
> > But wait, why do we even have this file at all? What's wrong with the
> > lib/lz4/ code that we have in the kernel today? Shouldn't the code
> > using these files be moved over to use the lib/ code instead and this
> > file be deleted?
>
> EROFS uses customized LZ4 decompression code for now (which has been offically
> supported in lz4 1.8.3, I have updated it in
> https://ozlabs.org/~akpm/mmots/broken-out/lib-lz4-update-lz4-decompressor-module.patch
> if it is shown up in Linux 4.20, I will remove all the customized LZ4 decompression code),
> but lib/ code lz4def.h isn't export to include/.

It should show up in 4.20, so you should be able to remove this all
then.

thanks,

greg k-h