Re: [PATCH] fbdev: fix broken menu dependencies

From: Bartlomiej Zolnierkiewicz
Date: Mon Oct 08 2018 - 06:52:38 EST



On 09/23/2018 12:43 AM, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
>
> The framebuffer options and devices menu is unintentionally split
> or broken because some items in it do not depend on FB (including
> several under omap and mmp).
> Fix this by moving FB_CMDLINE, FB_NOTIFY, and FB_CLPS711X_OLD to
> just before the FB Kconfig symbol definition and by moving the
> omap, omap2, and mmp menus to last, following FB_SM712.
>
> Also, the FB_VIA dependencies are duplicated by both being inside
> an "if FB_VIA/endif" block and "depends on FB_VIA", so drop the
> "depends on FB_VIA" lines since they are redundant.
>
> Fixes: ea6763c104c9 ("video/fbdev: Always built-in video= cmdline parsing")
> Fixes: 5ec9653806ba ("fbdev: Make fb-notify a no-op if CONFIG_FB=n")
> Fixes: ef74d46a4ef3 ("video: clps711x: Add new Cirrus Logic CLPS711X framebuffer driver")
>
> Signed-off-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
> Cc: Ezequiel Garcia <ezequiel@xxxxxxxxxxxxxxxxxxxx>
> Cc: Daniel Vetter <daniel.vetter@xxxxxxxx>
> Cc: Alexander Shiyan <shc_work@xxxxxxx>
> Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@xxxxxxxxxxx>
> Cc: dri-devel@xxxxxxxxxxxxxxxxxxxxx
> Cc: linux-fbdev@xxxxxxxxxxxxxxx

Patch queued for 4.20, thanks.

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics