Re: [PATCH v4 1/2] Bluetooth: Add device_get_bd_address()

From: Matthias Kaehlcke
Date: Thu Sep 27 2018 - 13:13:12 EST


On Thu, Sep 27, 2018 at 12:47:06PM -0400, Sinan Kaya wrote:
> On 9/27/2018 12:41 PM, Balakrishna Godavarthi wrote:
> > ÂvoidÂbt_sock_reclassify_lock(structÂsockÂ*sk,ÂintÂproto);
> >
> > +intÂdevice_get_bd_address(structÂdeviceÂ*dev,Âbdaddr_tÂ*bd_addr);
>
> Maybe change the API name to start with bt_ and get rid of device_?

device_ indicates that we get the BD_ADDR for a 'struct device' and
not for e.g. a 'struct fwnode_handle'.

Anyway with this version of the patch fwnode_get_bd_address() has been
scrapped and it might never be introduced again, so I'm open to change
the name to bt_ if there is a general preference for it.

Cheers

Matthias