Re: [PATCH v2] HID: logitech: fix a used uninitialized GCC warning

From: Jiri Kosina
Date: Mon Sep 24 2018 - 05:31:50 EST


On Thu, 13 Sep 2018, zhong jiang wrote:

> Fix the following compile warning:
>
> drivers/hid/hid-logitech-hidpp.c: In function 'hi_res_scroll_enable':
> drivers/hid/hid-logitech-hidpp.c:2714:54: warning: 'multiplier' may be used uninitialized in this function [-Wmaybe-uninitialized]
> hidpp->vertical_wheel_counter.resolution_multiplier = multiplier;
>
> Signed-off-by: zhong jiang <zhongjiang@xxxxxxxxxx>
> ---
> v1->v2:
> According to Benjamin's suggestion, To initialize the value
> and remove the duplicated assignement.

Applied to for-4.20/logitech-highres. Thanks,

--
Jiri Kosina
SUSE Labs