Re: [PATCH] perf tools: Do not zero sample_id_all for group members

[Andi Kleen]

On Sun, Sep 23, 2018 at 05:04:20PM +0200, Jiri Olsa wrote:
> Andi reported following malfunction:
> 
>   # perf record -e '{ref-cycles,cycles}:S' -a sleep 1
>   # perf script
>   non matching sample_id_all
> 
> That's because we disable sample_id_all bit for non-sampling
> group members. We can't do that, because it needs to be the
> same over the whole event list. This patch keeps it untouched
> again.
> 
> Fixes: e9add8bac6c6 ("perf evsel: Disable write_backward for leader sampling group events")
> Reported-by: Andi Kleen <andi@xxxxxxxxxxxxxx>
> Link: http://lkml.kernel.org/n/tip-y7hc1i6en4saxqxuwr2g24f1@xxxxxxxxxxxxxx
> Signed-off-by: Jiri Olsa <jolsa@xxxxxxxxxx>

Tested-by: Andi Kleen <ak@xxxxxxxxxxxxxxx>

Should be also cc stable please

-Andi