Re: [PATCH v8 1/3] powerpc: Detect the presence of big-cores via "ibm,thread-groups"

From: Gautham R Shenoy
Date: Fri Sep 21 2018 - 13:17:54 EST


Hello Michael,

On Fri, Sep 21, 2018 at 01:02:45PM +1000, Michael Neuling wrote:
> This doesn't compile for me with:
>
> arch/powerpc/kernel/smp.c: In function âsmp_prepare_cpusâ:
> arch/powerpc/kernel/smp.c:812:23: error: âtg.threads_per_groupâ may be used uninitialized in this function [-Werror=maybe-uninitialized]
> struct thread_groups tg;
> ^
> arch/powerpc/kernel/smp.c:812:23: error: âtg.nr_groupsâ may be used uninitialized in this function [-Werror=maybe-uninitialized]
> cc1: all warnings being treated as errors
> /home/mikey/src/linux-ozlabs/scripts/Makefile.build:305: recipe for target 'arch/powerpc/kernel/smp.o' failed
>

I couldn't get this error with gcc 4.8.5 and 8.1.1 with
pseries_defconfig and powernv_defconfig with CONFIG_PPC_WERROR=y.

Does the following the following delta patch make it work?

-----------------------------X8----------------------------------