Re: [REVIEW][PATCH 08/20] signal/x86/traps: Move setting error_code and trap_nr into do_trap_no_signal

From: Eric W. Biederman
Date: Fri Sep 21 2018 - 09:39:35 EST


ebiederm@xxxxxxxxxxxx (Eric W. Biederman) writes:

> I also realized for clarity of the code I could have moved show_signal
> into do_trap_no_signal as well. I will post a follow up change where I
> do that.

Except of course do_trap_no_signal does not take a signal number show
it can't call show signal. On second glance I don't see enough gain
to make it worth moving show_signal into do_trap_no_signal. So I am
just going to skip that for now.

Eric