Re: [REVIEW][PATCH 7/9] signal/poewrpc: Specialize _exception_pkey for handling pkey exceptions

[Christophe LEROY]

Le 21/09/2018 à 10:54, Stephen Rothwell a écrit :
> Hi Eric,
>
> On Tue, 18 Sep 2018 19:58:48 +0200 "Eric W. Biederman" <ebiederm@xxxxxxxxxxxx> wrote:
> > Now that _exception no longer calls _exception_pkey it is no longer
> > necessary to handle any signal with any si_code.  All pkey exceptions
> > are SIGSEGV with paired with SEGV_PKUERR.  So just handle
> > that case and remove the now unnecessary parameters from _exception_pkey.
> >
> > Signed-off-by: "Eric W. Biederman" <ebiederm@xxxxxxxxxxxx>
>
> Looks fine to me (small query below).
>
> Reviewed-by: Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx>

In the patch title, s/poewrpc/powerpc

> >   	clear_siginfo(&info);
> > -	info.si_signo = signr;
> > -	info.si_code = code;
> > +	info.si_signo = SIGSEGV;
> > +	info.si_code = SEGV_PKUERR;
> >   	info.si_addr = (void __user *) addr;
> >   	info.si_pkey = key;
> >   
> > -	force_sig_info(signr, &info, current);
> > +	force_sig_info(info.si_signo, &info, current);
>                         ^^^^^^^^^^^^^
> Why not just SIGSEGV?