Re: [PATCH RESEND] kvm/x86: propagate fetch fault into guest

From: Sean Christopherson
Date: Thu Sep 20 2018 - 13:43:07 EST


On Thu, Sep 20, 2018 at 06:32:10PM +0200, Paolo Bonzini wrote:
> On 19/09/2018 16:33, Sean Christopherson wrote:
> > On Tue, 2018-09-18 at 19:03 -0400, Peng Hao wrote:
> >> From: Peng Hao <peng.hao2@xxxxxxxxxx>
> >>
> >> When handling ept misconfig exit, it will call emulate instruction
> >> with insn_len = 0. The decode instruction function may return a fetch
> >> fault and should propagate to guest.
> >
> > What fault is encountered, e.g. #PF, #UD, etc...?  Something like a
> > #UD at this point should result in an exit to userspace as it means
> > KVM was unable to emulate an instruction that was successfully
> > decoded by hardware.
>
> If it's the same bug as https://lore.kernel.org/patchwork/patch/850077/
> it would be a #PF.

Indeed it is, let's move this discussion to that thread.