Re: [PATCH] jfs: remove redundant dquot_initialize() in jfs_evict_inode()

From: Dave Kleikamp
Date: Thu Sep 20 2018 - 10:25:12 EST


On 9/20/18 9:18 AM, Chao Yu wrote:
> Ping,
>
> Any comments?

Sorry for putting it off. It looks good to me. I'll push it upstream.

Thanks,
Dave

>
> On 2018/9/17 15:12, Chao Yu wrote:
>> We don't need to call dquot_initialize() twice in jfs_evict_inode(),
>> remove one of them for cleanup.
>>
>> Signed-off-by: Chao Yu <yuchao0@xxxxxxxxxx>
>> ---
>> fs/jfs/inode.c | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/fs/jfs/inode.c b/fs/jfs/inode.c
>> index 054cc761b426..805ae9e8944a 100644
>> --- a/fs/jfs/inode.c
>> +++ b/fs/jfs/inode.c
>> @@ -166,7 +166,6 @@ void jfs_evict_inode(struct inode *inode)
>> /*
>> * Free the inode from the quota allocation.
>> */
>> - dquot_initialize(inode);
>> dquot_free_inode(inode);
>> }
>> } else {
>>