Re: [PATCH] ARM: amba: Fix leak of driver_override attribute value

From: Geert Uytterhoeven
Date: Thu Sep 20 2018 - 03:16:50 EST


Hi Greg,

On Thu, Sep 20, 2018 at 9:09 AM Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
> On Thu, Sep 20, 2018 at 08:48:36AM +0200, Geert Uytterhoeven wrote:
> > On Thu, Sep 20, 2018 at 1:48 AM Trent Piepho <tpiepho@xxxxxxxxxx> wrote:
> > > If driver_override was set when a device was released the string would
> > > not be kfree'ed in amba_device_release and thus leaked when the amba
> > > device was freed.
> > >
> > > Cc: Russell King <linux@xxxxxxxxxxxxxxx>
> > > Cc: Todd Kjos <tkjos@xxxxxxxxxx>
> > > Cc: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> > > Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> > > Signed-off-by: Trent Piepho <tpiepho@xxxxxxxxxx>
> >
> > Reported-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> > Fixes: 3cf385713460eb2b ("ARM: 8256/1: driver coamba: add device
> > binding path 'driver_override'")
>
> Then it should also have a cc: stable, right?

Perhaps. I usually leave that up to the maintainer, else git send-email sends
it to stable immediately.

The modern backporting AI will consider it anyway, due to the subject, and
the Fixes tag, right?

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds