[PATCH] f2fs: avoid infinite loop in f2fs_alloc_nid

From: Jaegeuk Kim
Date: Wed Sep 19 2018 - 18:47:43 EST


If we have an error in f2fs_build_free_nids, we're able to fall into a loop
to find free nids.

Suggested-by: Chao Yu <chao@xxxxxxxxxx>
Signed-off-by: Jaegeuk Kim <jaegeuk@xxxxxxxxxx>
---
fs/f2fs/node.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/fs/f2fs/node.c b/fs/f2fs/node.c
index 79b6fee354f7..e24f8acbea82 100644
--- a/fs/f2fs/node.c
+++ b/fs/f2fs/node.c
@@ -2356,8 +2356,9 @@ bool f2fs_alloc_nid(struct f2fs_sb_info *sbi, nid_t *nid)
spin_unlock(&nm_i->nid_list_lock);

/* Let's scan nat pages and its caches to get free nids */
- f2fs_build_free_nids(sbi, true, false);
- goto retry;
+ if (!f2fs_build_free_nids(sbi, true, false))
+ goto retry;
+ return false;
}

/*
--
2.17.0.441.gb46fe60e1d-goog