Re: [PATCH v2] mtd: rawnand: atmel: Fix potential NULL pointer dereference

From: Miquel Raynal
Date: Wed Sep 19 2018 - 17:27:51 EST


Hi Gustavo,

"Gustavo A. R. Silva" <gustavo@xxxxxxxxxxxxxx> wrote on Tue, 18 Sep
2018 08:55:55 -0500:

> There is a potential execution path in which function
> of_find_compatible_node() returns NULL. In such a case,
> we end up having a NULL pointer dereference when accessing
> pointer *nfc_np* in function of_clk_get().
>
> So, we better don't take any chances and fix this by null
> checking pointer *nfc_np* before calling of_clk_get().
>
> Addresses-Coverity-ID: 1473052 ("Dereference null return value")
> Fixes: f88fc122cc34 ("mtd: nand: Cleanup/rework the atmel_nand driver")
> Signed-off-by: Gustavo A. R. Silva <gustavo@xxxxxxxxxxxxxx>
> ---

Applied to nand/next.

Thanks,
MiquÃl