Re: [PATCH net-next] net: toshiba: fix return type of ndo_start_xmit function

From: Geoff Levand
Date: Wed Sep 19 2018 - 12:11:02 EST


Hi Yue,

On 09/19/2018 03:23 AM, YueHaibing wrote:
> The method ndo_start_xmit() is defined as returning an 'netdev_tx_t',
> which is a typedef for an enum type, so make sure the implementation in
> this driver has returns 'netdev_tx_t' value, and change the function
> return type to netdev_tx_t.
>
> Found by coccinelle.
>
> Signed-off-by: YueHaibing <yuehaibing@xxxxxxxxxx>

I tested this against Linux-4.19-rc4, and it seemed to work OK.

Please remove the irrelevant line 'Found by coccinelle.' from the
commit message. With that change:

Acked-by: Geoff Levand <geoff@xxxxxxxxxxxxx>

-Geoff