Re: [PATCH 04/12][RFC v3] x86, hibernate: Extract the common code of 64/32 bit system

From: Ingo Molnar
Date: Wed Sep 19 2018 - 06:34:13 EST



* Rafael J. Wysocki <rafael@xxxxxxxxxx> wrote:

> > index 000000000000..fbde8f0e8fe0
> > --- /dev/null
> > +++ b/arch/x86/power/hibernate.c
> > @@ -0,0 +1,249 @@
> > +// SPDX-License-Identifier: GPL-2.0
> > +/*
> > + * Hibernation support for x86
> > + *
> > + * Copyright (c) 2007 Rafael J. Wysocki <rjw@xxxxxxx>
> > + * Copyright (c) 2002 Pavel Machek <pavel@xxxxxx>
> > + * Copyright (c) 2001 Patrick Mochel <mochel@xxxxxxxx>
>
> I don't think this "copyright" information has any legal bearing any
> more at this point.

I think that's wrong in general, and it's routine for corporate legal
departments to insist on specific boilerplate copyright notices when
OSS code is contributed.

Copying code and then removing copyright notices is frowned upon
independently as well.

While you can probably talk for your own copyright notice, I'm not sure
it's true of the two other historic copyright notices that were copied.

So I think it's best practice to preserve all copyright notices as-is.

Thanks,

Ingo