Re: [REVIEW][PATCH 02/20] signal/x86: Inline fill_sigtrap_info in it's only caller send_sigtrap

From: Christoph Hellwig
Date: Wed Sep 19 2018 - 01:49:08 EST


>
> clear_siginfo(&info);
> - fill_sigtrap_info(tsk, regs, error_code, si_code, &info);
> + tsk->thread.trap_nr = X86_TRAP_DB;
> + tsk->thread.error_code = error_code;
> +
> + info.si_signo = SIGTRAP;
> + info.si_code = si_code;
> + info.si_addr = user_mode(regs) ? (void __user *)regs->ip : NULL;

clear_siginfo already zeroes the whole structure, so this could be
written more clearly as:

if (user_mode(regs)
info.si_addr = (void __user *)regs->ip;