Re: [patch V3 02/11] x86/mm/cpa: Split, rename and clean up try_preserve_large_page()

From: Peter Zijlstra
Date: Tue Sep 18 2018 - 03:04:03 EST


On Mon, Sep 17, 2018 at 04:29:08PM +0200, Thomas Gleixner wrote:
> Avoid the extra variable and gotos by splitting the function into the
> actual algorithm and a callable function which contains the lock
> protection.
>
> Rename it to should_split_large_page() while at it so the return values make
> actually sense.

Much thanks, that makes the whole thing much saner.