Re: [PATCH v3,net-next 1/2] ip_gre: fix parsing gre header in ipgre_err

From: David Miller
Date: Sun Sep 16 2018 - 18:34:30 EST


From: Haishuang Yan <yanhaishuang@xxxxxxxxxxxxxxxxxxxx>
Date: Fri, 14 Sep 2018 12:26:47 +0800

> gre_parse_header stops parsing when csum_err is encountered, which means
> tpi->key is undefined and ip_tunnel_lookup will return NULL improperly.
>
> This patch introduce a NULL pointer as csum_err parameter. Even when
> csum_err is encountered, it won't return error and continue parsing gre
> header as expected.
>
> Fixes: 9f57c67c379d ("gre: Remove support for sharing GRE protocol hook.")
> Reported-by: Jiri Benc <jbenc@xxxxxxxxxx>
> Signed-off-by: Haishuang Yan <yanhaishuang@xxxxxxxxxxxxxxxxxxxx>
>
> ---
> Changes since v3:
> * skb_checksum_simple_validate need to be performed in csum_err case.

Applied.