Re: [PATCH 04/20] platform: goldfish: pipe: Separate the host interface to a separate header

From: Greg KH
Date: Fri Sep 14 2018 - 09:29:44 EST


On Mon, Aug 27, 2018 at 11:22:59AM -0700, rkir@xxxxxxxxxx wrote:
> --- /dev/null
> +++ b/drivers/platform/goldfish/goldfish_pipe_qemu.h
> @@ -0,0 +1,112 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> +/*
> + * Copyright (C) 2018 Google, Inc.
> + *
> + * This software is licensed under the terms of the GNU General Public
> + * License version 2, as published by the Free Software Foundation, and
> + * may be copied, distributed, and modified under those terms.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> + * GNU General Public License for more details.

When you have a SPDX line, you do not also need the boilerplate license
text in this file as well. So you can remove that please. A later
patch is fine.

thanks,

greg k-h