Re: [PATCH] staging: rtl8188eu: change array type to u8

From: Joe Perches
Date: Tue Sep 11 2018 - 17:05:19 EST


On Mon, 2018-09-10 at 22:38 +0200, Michael Straube wrote:
> The the last two parameters of write_cam() have type u8.
> Change the type of the passed arrays from unsigned char to u8.
> Clears a line over 80 characters checkpatch warning.
>
> Signed-off-by: Michael Straube <straube.linux@xxxxxxxxx>
> ---
> drivers/staging/rtl8188eu/core/rtw_wlan_util.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/rtl8188eu/core/rtw_wlan_util.c b/drivers/staging/rtl8188eu/core/rtw_wlan_util.c
> index 3e0801858737..fb496ab5a862 100644
> --- a/drivers/staging/rtl8188eu/core/rtw_wlan_util.c
> +++ b/drivers/staging/rtl8188eu/core/rtw_wlan_util.c
> @@ -454,9 +454,9 @@ void write_cam(struct adapter *padapter, u8 entry, u16 ctrl, u8 *mac, u8 *key)
>
> void clear_cam_entry(struct adapter *padapter, u8 entry)
> {
> - unsigned char null_sta[] = {0x00, 0x00, 0x00, 0x00, 0x00, 0x00};
> - unsigned char null_key[] = {0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> - 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00};
> + u8 null_sta[] = {0x00, 0x00, 0x00, 0x00, 0x00, 0x00};
> + u8 null_key[] = {0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00};

static const

could also be written

static const u8 null_sta[ETH_ALEN] = {};
static const u8 null_key[16] = {};

>
> write_cam(padapter, entry, 0, null_sta, null_key);
> }