Re: [PATCH 11/11] dts: tc2: Update coresight bindings for hardware ports

From: Sudeep Holla
Date: Tue Sep 11 2018 - 13:23:38 EST




On 11/09/18 18:15, Suzuki K Poulose wrote:
> On 09/11/2018 06:01 PM, Sudeep Holla wrote:
>> On Tue, Sep 11, 2018 at 11:17:12AM +0100, Suzuki K Poulose wrote:
>>> Switch to the new coresight bindings
>>>
>>
>> I still see the below warnings:
>>
>> vexpress-v2p-ca15_a7.dtb: Warning (graph_child_address):
>> ÂÂÂÂ/replicator/in-ports: graph node has single child node 'port@0',
>> ÂÂÂÂ#address-cells/#size-cells are not necessary
>> vexpress-v2p-ca15_a7.dtb: Warning (graph_child_address):
>> ÂÂÂÂ/funnel@20040000/out-ports: graph node has single child node
>> 'port@0',
>> ÂÂÂÂ#address-cells/#size-cells are not necessary
>>
>> I need the below patch to fix them, let me know if it looks OK, I can
>> amend and apply.
>
> Thanks for reporting. I purposefully added the "address-cells" and
> followed the format everywhere in the series thinking that, that is
> indeed the formal way of doing it, rather than having implicit port
> numbers. I can send an updated series fixing it everywhere.
>
No need to post the update for TC2 unless it's different from what I
have proposed.

--
Regards,
Sudeep