Re: [PATCH] arm64: dts: meson-axg-s400: Add chosen and memory nodes

From: Neil Armstrong
Date: Tue Sep 11 2018 - 09:28:58 EST


Hi Martin,

On 10/09/2018 20:45, Martin Blumenstingl wrote:
> On Mon, Sep 10, 2018 at 8:33 PM Neil Armstrong <narmstrong@xxxxxxxxxxxx> wrote:
>>
>> Add missing chosen and memory nodes.
>>
>> Signed-off-by: Neil Armstrong <narmstrong@xxxxxxxxxxxx>
> out of curiosity:
> - does the bootloader add the memory node (meaning that this is just a
> cosmetic bit)?

Yes, but it's always better to already have the node so it only change the memory,
otherwise it has to relocate and insert a node in the middle of the dtb.

> - setting stdout-path is always a good idea, without it you can't use
> earlycon (without parameters)
>
> Acked-by: Martin Blumenstingl <martin.blumenstingl@xxxxxxxxxxxxxx>
>

Thanks,
Neil