Re: [PATCH v2 1/2] dmaengine: Add metadata_ops for dma_async_tx_descriptor

From: Peter Ujfalusi
Date: Tue Sep 11 2018 - 08:33:43 EST


Vinod,

On 2018-09-11 10:33, Vinod wrote:
>> +int dmaengine_desc_attach_metadata(struct dma_async_tx_descriptor *desc,
>> + void *data, size_t len)
>> +{
>> + int ret;
>> +
>> + if (!desc)
>> + return -EINVAL;
>> +
>> + ret = desc_check_and_set_metadata_mode(desc, DESC_METADATA_CLIENT);
>> + if (ret)
>> + return ret;
>> +
>> + if (!desc->metadata_ops || !desc->metadata_ops->attach)
>> + return -ENOTSUPP;
>> +
>> + return desc->metadata_ops->attach(desc, data, len);
>> +}
>> +EXPORT_SYMBOL(dmaengine_desc_attach_metadata);
>
> EXPORT_SYMBOL_GPL ?

Sure, I think I have looked at
dma_async_tx_descriptor_init/dmaengine_get_unmap_data/dma_issue_pending_all/etc
they have EXPORT_SYMBOL()

- PÃter

Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki