Re: [PATCH 19/20] staging:rtl8192u: Rename LINIP - Style

From: Greg KH
Date: Mon Sep 10 2018 - 11:09:47 EST


On Sat, Sep 01, 2018 at 12:02:49AM +0100, John Whitmore wrote:
> Rename the member variable 'LINIP' to 'linip', this change is to
> conform to the coding style guidelines, member variables in
> lowercase.
>
> This is a simple coding style change which should not impact runtime
> code execution.
>
> Signed-off-by: John Whitmore <johnfwhitmore@xxxxxxxxx>
> ---
> drivers/staging/rtl8192u/r8192U.h | 2 +-
> drivers/staging/rtl8192u/r8192U_core.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/rtl8192u/r8192U.h b/drivers/staging/rtl8192u/r8192U.h
> index 66efa59eabf0..68e82b32a88e 100644
> --- a/drivers/staging/rtl8192u/r8192U.h
> +++ b/drivers/staging/rtl8192u/r8192U.h
> @@ -164,7 +164,7 @@ struct tx_desc_819x_usb {
> u8 cmd_init:1;
> u8 last_seg:1;
> u8 first_seg:1;
> - u8 LINIP:1;
> + u8 linip:1;
> u8 OWN:1;
>
> /* DWORD 1 */
> diff --git a/drivers/staging/rtl8192u/r8192U_core.c b/drivers/staging/rtl8192u/r8192U_core.c
> index a4d1b55a1117..911d0214b48a 100644
> --- a/drivers/staging/rtl8192u/r8192U_core.c
> +++ b/drivers/staging/rtl8192u/r8192U_core.c
> @@ -1514,7 +1514,7 @@ short rtl8192_tx(struct net_device *dev, struct sk_buff *skb)
> /* Fill Tx descriptor */
> memset(tx_desc, 0, sizeof(struct tx_desc_819x_usb));
> /* DWORD 0 */
> - tx_desc->LINIP = 0;
> + tx_desc->linip = 0;

Please just delet.