Re: [PATCH v2 0/4] Add support for Arm Framebuffer Compression(AFBC)

[Neil Armstrong]

Hi Ayan,

On 10/07/2018 15:18, Ayan Kumar Halder wrote:
> In the current series of patches, we are trying to add support for AFBC
> modifiers in malidp. AFBC modifiers adds some constraints to framebuffer
> size, alignment, pitch, formats, etc. Here we are trying to add support
> for one combination of AFBC modifier ie AFBC_FORMAT_MOD_BLOCK_SIZE_16x16 |
> AFBC_FORMAT_MOD_SPARSE | AFBC_FORMAT_MOD_YTR.
> In future, we intend to add support for more combination of AFBC modifiers.
> Currently, we are trying to enable a basic support of AFBC in malidp.

Thanks for pushing AFBC support, this will help supporting it on other SoCs implementing support
like Amlogic, Rockchip or Samsung.

I have one question, is there a way to generate such AFBC buffers without the Mali GPU ?
I mean, is there a way to generate some sample buffers with some of the modifier features
to validate it without having the complete Mali GPU -> DRM chain ?

Thanks in advance,
Neil

> 
> Changes from v2:
> - Added ack by Maarten Lankhorst <maarten.lankhorst@xxxxxxxxxxxxxxx>
> for patch 1. However, this has been kept in this series in order to help
> reviewers review the other patches (which are related to patch 1)
> - For patches 2 and 4, replaced DRM_ERROR() with DRM_DEBUG_KMS()
> - For patch 3, reworked malidp_de_set_plane_afbc() so as to consolidate
> all afbc specific register configuration in this.
> 
> Ayan Kumar Halder (4):
>   drm/arm/malidp: Add modifier definitions for describing Arm
>     Framebuffer Compression (AFBC).
>   drm/arm/malidp: Implemented the size validation for AFBC framebuffers
>   drm/arm/malidp: Set the AFBC register bits if the framebuffer has AFBC
>     modifier
>   drm/arm/malidp: Added support for AFBC modifiers for all layers except
>     DE_SMART
> 
>  drivers/gpu/drm/arm/malidp_drv.c    | 129 +++++++++++++++++++++++++++++++++++-
>  drivers/gpu/drm/arm/malidp_hw.c     |  27 +++++---
>  drivers/gpu/drm/arm/malidp_hw.h     |   7 ++
>  drivers/gpu/drm/arm/malidp_planes.c | 129 +++++++++++++++++++++++++++++++++---
>  drivers/gpu/drm/arm/malidp_regs.h   |  20 ++++++
>  include/uapi/drm/drm_fourcc.h       |  83 +++++++++++++++++++++++
>  6 files changed, 373 insertions(+), 22 deletions(-)
>