Re: [PATCH v2] EDAC, ghes: use CPER module handles to locate DIMMs

From: Kani, Toshi
Date: Thu Aug 30 2018 - 17:29:16 EST


On Thu, 2018-08-30 at 18:37 +0000, Fan Wu wrote:
> For platforms whose firmwares provide valid module handles
> (SMBIOS type 17) in error records, this patch uses the module
> handles to locate corresponding DIMMs and enables per-DIMM
> error counter update.
>
> Signed-off-by: Fan Wu <wufan@xxxxxxxxxxxxxx>

Tested on an HPE x86 server. It turns out that mem_err->mem_dev_handle
was set to 0 with this FW, and get_dimm_smbios_index() returned -1. But
the code handles this case fine. dimm->smbios_handle's were initialized
properly. So:

Tested-by: Toshi Kani <toshi.kani@xxxxxxx>

Thanks,
-Toshi