Re: [PATCH tip/core/rcu 0/52] Remove rcu_state pointers for v4.20/v5.0

From: Josh Triplett
Date: Thu Aug 30 2018 - 00:29:40 EST


On Wed, Aug 29, 2018 at 09:10:17PM -0700, Paul E. McKenney wrote:
> On Wed, Aug 29, 2018 at 08:22:16PM -0700, Paul E. McKenney wrote:
> > On Wed, Aug 29, 2018 at 10:00:26PM -0400, Steven Rostedt wrote:
> > > On Wed, 29 Aug 2018 15:38:30 -0700
> > > "Paul E. McKenney" <paulmck@xxxxxxxxxxxxxxxxxx> wrote:
> > >
> > > > Hello!
> > > >
> > > > This commit does RCU-consolidation cleanups that get rid of pointers to
> > > > the sole remaining rcu_state structure:
> > > >
> > > > 1-40: Remove the "rsp" parameter from numerous functions, given that
> > > > the corresponding argument will always be &rcu_state.
> > >
> > > Hmm, couldn't 1-40 have been made into a single patch?
> >
> > They could. I separated them to make finding the inevitable typos easier.
> > But at this point, it is easy enough to squash them together, though.
>
> And please see below for what the resulting diff would look like. Is
> this an improvement?

Honestly, as long as the result after each commit compiles, I prefer the
split version for ease of review.