Re: [PATCH] block, bfq: return nbytes and not zero from struct cftype .write() method

From: Jens Axboe
Date: Fri Aug 17 2018 - 13:39:05 EST


On 8/17/18 11:27 AM, Maciej S. Szmigiero wrote:
> On 16.08.2018 21:11, Jens Axboe wrote:
>> On 8/15/18 3:56 PM, Maciej S. Szmigiero wrote:
>>> The value that struct cftype .write() method returns is then directly
>>> returned to userspace as the value returned by write() syscall, so it
>>> should be the number of bytes actually written (or consumed) and not zero.
>>>
>>> Returning zero from write() syscall makes programs like /bin/echo or bash
>>> spin.
>>
>> Applied, thanks.
>
> Thanks.
>
>> Just a heads-up that gmail thinks your email is spam.
>
> Thanks for the information - it looks like gmail just doesn't like my
> email server for some reason.

This one came through fine, jfyi.

--
Jens Axboe