Re: [PATCH] platform/x86: acer-wmi: Silence "unsupported" message a bit

From: Andy Shevchenko
Date: Fri Aug 17 2018 - 07:07:42 EST


On Thu, Aug 16, 2018 at 2:27 AM, Benjamin Herrenschmidt
<benh@xxxxxxxxxxxxxxxxxxx> wrote:
> This driver prints that "Unsupported machine..." message on every boot on
> ThinkPad X1 Carbon laptops (and I assume a number of other systems), which
> causes graphical boots to "glitch" a bit and is rather annoying ...
>
> Make it a pr_debug instead.

Thanks for the patch. Unfortunately it doesn't apply.
Please, check your mail clients and tools for formatting patch (it
produced at the end spaces instead of tabs)

>
> Signed-off-by: Benjamin Herrenschmidt <benh@xxxxxxxxxxxxxxxxxxx>
> ---
>
> diff --git a/drivers/platform/x86/acer-wmi.c b/drivers/platform/x86/acer-wmi.c
> index 8952173dd380..7f7192e8fdab 100644
> --- a/drivers/platform/x86/acer-wmi.c
> +++ b/drivers/platform/x86/acer-wmi.c
> @@ -2216,7 +2216,7 @@ static int __init acer_wmi_init(void)
> if (wmi_has_guid(AMW0_GUID1) &&
> !dmi_check_system(amw0_whitelist) &&
> quirks == &quirk_unknown) {
> - pr_err("Unsupported machine has AMW0_GUID1, unable to load\n");
> + pr_debug("Unsupported machine has AMW0_GUID1, unable to load\n");
> return -ENODEV;
> }
>
>



--
With Best Regards,
Andy Shevchenko