Re: [PATCH 3/4] ARM64: dts: meson-gx: add dmcbus and canvas nodes.

From: Yixun Lan
Date: Mon Aug 06 2018 - 21:30:03 EST


hi Maxime:

On Sun, Aug 5, 2018 at 4:02 AM, Maxime Jourdan <maxi.jourdan@xxxxxxxxxx> wrote:
>>> + sysctrl_DMC: system-controller@0 {
>>> + compatible = "amlogic,meson-gx-dmc-sysctrl", "syscon", "simple-mfd";
>>
>> we'd like to drop 'meson-' prefix, so better using "amlogic,gx-dmc-sysctrl",
>> please take a look at the discussion here [1]
>>
>> [1] https://lkml.kernel.org/r/7hk1prmg4w.fsf@xxxxxxxxxxxx
>>
>
> On that subject, should I remove the meson keyword from dts only, or
> from everything ?
>
remove the 'meson-' from dts is enough..

> e.g use amlogic_canvas_* symbols instead of meson_canvas_*, name the
> source file "amlogic-canvas.c", etc. ?
>
Actually, I'd suggest to keep using meson_canvas_* in the code for the
consistency,
unless Kevin or Jerome/Neil has something to say?

Yixun