Re: [PATCH] aoe: mark expected switch fall-through

[Ed Cashin]

On Wed, Aug 1, 2018 at 6:30 PM Gustavo A. R. Silva <gustavo@xxxxxxxxxxxxxx> wrote:

In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.

OK, thanks.

Â

diff --git a/drivers/block/aoe/aoecmd.c b/drivers/block/aoe/aoecmd.c
index 096882e..136dc50 100644
--- a/drivers/block/aoe/aoecmd.c
+++ b/drivers/block/aoe/aoecmd.c
@@ -1137,6 +1137,7 @@ noskb:Â Â Â Â Â Â if (buf)
            break;
        }
        bvcpy(skb, f->buf->bio, f->iter, n);
+Â Â Â Â Â Â Â Â/* fall through */
    case ATA_CMD_PIO_WRITE:
    case ATA_CMD_PIO_WRITE_EXT:
        spin_lock_irq(&d->lock);
--
2.7.4

--

 Ed Cashin <ecashin@xxxxxxxxxxxx>