Re: [PATCH] net/9p/trans_virtio.c: add a terminal char for mount tag

From: piaojun
Date: Wed Aug 01 2018 - 21:19:52 EST


Hi Dominique and Greg,

Thanks for your reviewing, and I will try to simplify other related code
according your suggestions in patch v2.

Thanks,
Jun

On 2018/8/1 20:09, Dominique Martinet wrote:
> Greg Kurz wrote on Wed, Aug 01, 2018:
>> So this patch basically turns chan->tag into a nul terminated string,
>> which is indeed more convenient and robust. Maybe you can update the
>> rest of the code accordingly and drop chan->tag_len then ?
>
> If we can use that to simplify some other part of the code, that's
> certainly more appealing to me :)
>
>
>> FWIW, 9P strings received from the client are also converted to
>> nul terminated strings:
>
> Oh, good to know; I guess that makes sense when these strings come and
> go from/to other components of the kernel that likely expect that.
>