Re: [PATCH] block: ioprio: Replace GFP_ATOMIC with GFP_KERNEL in set_task_ioprio()

[Tetsuo Handa]

On 2018/07/23 16:18, Christoph Hellwig wrote:
> Looks good,

Looks bad. :-(

SYSCALL_DEFINE3(ioprio_set, int, which, int, who, int, ioprio)
{
(...snipped...)
	rcu_read_lock();
(...snipped...)
	ret = set_task_ioprio(p, ioprio);
(...snipped...)
	rcu_read_unlock();
(...snipped...)
}

> 
> Reviewed-by: Christoph Hellwig <hch@xxxxxx>
> 
> But to me it seems that btrfs and maybe ext4 as well would be much
> better off just setting a per-IO priority in the bio.
> 
> Any chance yo could look into that?
>