Re: [PATCH] bluetooth: btusb: Replace GFP_ATOMIC with GFP_KERNEL in inject_cmd_complete()

From: Marcel Holtmann
Date: Mon Jul 23 2018 - 12:06:02 EST


Hi Jia-Ju,

> inject_cmd_complete() is only called by btusb_send_frame_intel(),
> which is set to hdev->send, and hdev->send() is never
> called in atomic context.
>
> inject_cmd_complete() calls bt_skb_alloc() with GFP_ATOMIC,
> which is not necessary.
> GFP_ATOMIC can be replaced with GFP_KERNEL.
>
> This is found by a static analysis tool named DCNS written by myself.
> I also manually check the kernel code before reporting it.
>
> Signed-off-by: Jia-Ju Bai <baijiaju1990@xxxxxxxxx>
> ---
> drivers/bluetooth/btusb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

all 6 patches have been applied to bluetooth-next tree.

Regards

Marcel