Re: [PATCH v2 00/19] Fixes for sched/numa_balancing

From: Rik van Riel
Date: Mon Jul 23 2018 - 11:33:11 EST


On Mon, 2018-07-23 at 08:09 -0700, Srikar Dronamraju wrote:
> * Peter Zijlstra <peterz@xxxxxxxxxxxxx> [2018-07-23 15:57:00]:
>
> > On Wed, Jun 20, 2018 at 10:32:41PM +0530, Srikar Dronamraju wrote:
> > > Srikar Dronamraju (19):
> >
> > > sched/numa: Stop multiple tasks from moving to the cpu at the
> > > same time
>
> This patch has go-ahead from Mel and Rik and no outstanding comments.
>
> In my analysis, I did find a lot of cases where the same cpu ended up
> being the target. + I am not sure you can apply "sched/numa: Restrict
> migrating in parallel to the same node" cleanly without this patch.
>
> So I am a bit confused. If possible, please clarify.

I believe that patch fixes a real issue, but it would
be nice if the code could be documented better so it
does not confuse people who look at the code later.


--
All Rights Reversed.

Attachment: signature.asc
Description: This is a digitally signed message part