Re: [PATCH] Add a missing break in parse_station_flags

From: Kalle Valo
Date: Mon Jul 23 2018 - 05:30:48 EST


Bernd Edlinger <bernd.edlinger@xxxxxxxxxx> writes:

> I was looking at usually suppressed gcc warnings,
> [-Wimplicit-fallthrough=] in this case:
>
> The code definitely looks like a break is missing here.
> However I am not able to test the NL80211_IFTYPE_MESH_POINT,
> nor do I actually know what might be :)
> So please use this patch with caution and only if you are
> able to do some testing.
>
> Signed-off-by: Bernd Edlinger <bernd.edlinger@xxxxxxxxxx>
> ---
> net/wireless/nl80211.c | 1 +
> 1 file changed, 1 insertion(+)

You should use prefix "nl80211: " in the title.

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#subject

--
Kalle Valo