Re: [PATCH v6 5/6] i2c: Add Actions Semiconductor Owl family S900 I2C driver

From: Peter Rosin
Date: Mon Jul 23 2018 - 02:12:32 EST


On 2018-07-23 05:40, Manivannan Sadhasivam wrote:
> + /* Handle the remaining bytes which were not sent */
> + while (!(readl(i2c_dev->base + OWL_I2C_REG_FIFOSTAT) &
> + OWL_I2C_FIFOSTAT_TFF) && i2c_dev->msg_ptr < msg->len) {

You moved the OWL_ line to the left instead of right, so this is still
misaligned and thus not helping the reader.

Cheers,
Peter

> + writel(msg->buf[i2c_dev->msg_ptr++],
> + i2c_dev->base + OWL_I2C_REG_TXDAT);
> + }