Re: [PATCH v2 1/3] vt: avoid a VLA in the unicode screen scroll function

From: Greg Kroah-Hartman
Date: Sat Jul 21 2018 - 03:21:14 EST


On Thu, Jul 19, 2018 at 12:05:25AM -0400, Nicolas Pitre wrote:
>
> The nr argument is typically small: most often nr == 1. However this
> could be abused with a very large explicit scroll in a resized screen.
> Make the code scroll lines by performing an array rotation operation to
> avoid the need for a large temporary space.
>
> Requested-by: Kees Cook <keescook@xxxxxxxxxxxx>
> Suggested-by: Adam Borowski <kilobyte@xxxxxxxxxx>
> Signed-off-by: Nicolas Pitre <nico@xxxxxxxxxx>

I've now applied this v2 of the patch, thanks for this.

greg k-h