Re: [PATCH 1/2] gpiolib: don't allow userspace to set values of input lines

From: Linus Walleij
Date: Fri Jul 20 2018 - 16:34:02 EST


On Mon, Jul 16, 2018 at 4:13 PM Bartosz Golaszewski <brgl@xxxxxxxx> wrote:
> 2018-07-16 15:40 GMT+02:00 Linus Walleij <linus.walleij@xxxxxxxxxx>:
> > On Mon, Jul 16, 2018 at 10:34 AM Bartosz Golaszewski <brgl@xxxxxxxx> wrote:
> >
> >> User space can currently both read and set values of input lines using
> >> the character device. This was not allowed by the old sysfs interface
> >> nor is it a correct behavior.
> >>
> >> Check the first descriptor in the set for the OUT flag when asked to
> >> set values and return -EPERM if the line is input.
> >>
> >> Signed-off-by: Bartosz Golaszewski <brgl@xxxxxxxx>
> >
> > Patch applied! Thanks for fixing this.
>
> Thanks. Do you think we should Cc stable on that one?

Nah. It's not a regression. (Not like things that worked before
stopped working.)

Yours,
Linus Walleij