Re: [PATCH] of: overlay: update phandle cache on overlay apply and remove

From: Rob Herring
Date: Fri Jul 20 2018 - 11:06:54 EST


On Thu, Jul 12, 2018 at 02:00:07PM -0700, frowand.list@xxxxxxxxx wrote:
> From: Frank Rowand <frank.rowand@xxxxxxxx>
>
> A comment in the review of the patch adding the phandle cache said that
> the cache would have to be updated when modules are applied and removed.
> This patch implements the cache updates.
>
> Fixes: 0b3ce78e90fc ("of: cache phandle nodes to reduce cost of of_find_node_by_phandle()")
> Reported-by: Alan Tull <atull@xxxxxxxxxx>
> Suggested-by: Alan Tull <atull@xxxxxxxxxx>
> Signed-off-by: Frank Rowand <frank.rowand@xxxxxxxx>
> ---
>
> Changes since RFC:
> - update code comment to mention race condition avoidance
>
> For the RFC version of this patch, the 0day test reported a general
> protection fault from the KASAN runtime memory debugger on x86_64
> in qemu. The GPF was in a devicetree unittest.
>
> 0day tested the patch on v4.17-rc1, with some other patches applied.
> I was unable to replicate the GPF on v4.18-rc1 with just this patch
> applied. I was also unable to replicate the GPF on a clone of the
> v4.17-rc1 0day repository, using the 0day kernel config. I will
> reply to this email with the 0day GPF report.

Didn't see any 0-day issues, so I've applied and it is in Linus' tree
now.

Rob