Re: [PATCH] proc: fixup PDE allocation bloat

[Shakeel Butt]

On Sun, Jun 17, 2018 at 2:57 PM Alexey Dobriyan <adobriyan@xxxxxxxxx> wrote:
>
> commit 24074a35c5c975c94cd9691ae962855333aac47f
> ("proc: Make inline name size calculation automatic")
> started to put PDE allocations into kmalloc-256 which is unnecessary as
> ~40 character names are very rare.
>
> Put allocation back into kmalloc-192 cache for 64-bit non-debug builds.
>
> Put BUILD_BUG_ON to know when PDE size is gotten out of control.
>
> Signed-off-by: Alexey Dobriyan <adobriyan@xxxxxxxxx>
> ---
>
>  fs/proc/inode.c    |    6 ++++--
>  fs/proc/internal.h |   17 +++++++----------
>  2 files changed, 11 insertions(+), 12 deletions(-)
>
> --- a/fs/proc/inode.c
> +++ b/fs/proc/inode.c
> @@ -105,8 +105,10 @@ void __init proc_init_kmemcache(void)
>                 kmem_cache_create("pde_opener", sizeof(struct pde_opener), 0,
>                                   SLAB_ACCOUNT|SLAB_PANIC, NULL);
>         proc_dir_entry_cache = kmem_cache_create_usercopy(
> -               "proc_dir_entry", SIZEOF_PDE_SLOT, 0, SLAB_PANIC,
> -               OFFSETOF_PDE_NAME, SIZEOF_PDE_INLINE_NAME, NULL);
> +               "proc_dir_entry", SIZEOF_PDE, 0, SLAB_PANIC,

Hi Alexey, can you comment if proc_dir_entry_cache should or shouldn't
have SLAB_ACCOUNT flag?

Shakeel