Re: [PATCH] tpm: add support for partial reads

From: James Bottomley
Date: Thu Jul 19 2018 - 16:27:47 EST


On Thu, 2018-07-19 at 13:12 -0700, Tadeusz Struk wrote:
> On 07/19/2018 12:52 PM, James Bottomley wrote:
> > The ABI break is the error case as I outlined above.ÂÂWe can't
> > assume everyone uses the current interface without getting an error
> > and one error and your hosed is a nasty failure case to change the
> > interface to.Â
>
> Well, if there is a broken application out there that doesn't work
> today it will not work after this change neither.

It doesn't have to be broken ... it could be using EFAULT to probe the
buffer size for instance. That's the point of not breaking the ABI:
you don't second guess what applications are doing.

James