RE: [PATCH] mm: Cleanup in do_shrink_slab()

[David Laight]

From: Kirill Tkhai
> Sent: 19 July 2018 17:05
> 
> Group long variables together to minimize number of occupied lines
> and place all definitions in back Christmas tree order.

Grouping together unrelated variables doesn't really make the code
any more readable.
IMHO One variable per line is usually best.

> Also, simplify expression around batch_size: use all power of C language!

   foo = bar ? : baz;
Is not part of C, it is a gcc extension.

	David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)