Re: [PATCH] power: supply: max77693_charger: fix unintentional fall-through

From: Gustavo A. R. Silva
Date: Thu Jul 19 2018 - 09:55:04 EST


Hi Krzysztof,

On 07/18/2018 01:14 AM, Krzysztof Kozlowski wrote:
> On 17 July 2018 at 23:47, Gustavo A. R. Silva <gustavo@xxxxxxxxxxxxxx> wrote:
>> It seems that a *break* is missing in order to avoid a fall-through.
>> Otherwise, the calculation of *data* makes no sense.
>>
>> Addresses-Coverity-ID: 1271172 ("Missing break in switch")
>> Fixes: 87c2d9067893 ("power: max77693: Add charger driver for Maxim 77693")
>> Signed-off-by: Gustavo A. R. Silva <gustavo@xxxxxxxxxxxxxx>
>> ---
>> drivers/power/supply/max77693_charger.c | 1 +
>> 1 file changed, 1 insertion(+)
>
> Reviewed-by: Krzysztof Kozlowski <krzk@xxxxxxxxxx>
>

BTW, I think this also should be tagged for stable.

Thanks
--
Gustavo