Re: [PATCH v3 4/8] swap: Unify normal/huge code path in swap_page_trans_huge_swapped()

From: Christoph Hellwig
Date: Thu Jul 19 2018 - 08:40:17 EST


> static inline bool cluster_is_huge(struct swap_cluster_info *info)
> {
> - return info->flags & CLUSTER_FLAG_HUGE;
> + if (IS_ENABLED(CONFIG_THP_SWAP))
> + return info->flags & CLUSTER_FLAG_HUGE;
> + else
> + return false;

Nitpick: no need for an else after a return:

if (IS_ENABLED(CONFIG_THP_SWAP))
return info->flags & CLUSTER_FLAG_HUGE;
return false;