RE: [PATCH] ARM: dts: imx7d: add missing OPP property for cpu0

[Anson Huang]

Hi, Shawn

Anson Huang
Best Regards!


> -----Original Message-----
> From: Shawn Guo [mailto:shawnguo@xxxxxxxxxx]
> Sent: Thursday, July 19, 2018 11:20 AM
> To: Anson Huang <anson.huang@xxxxxxx>; Viresh Kumar
> <viresh.kumar@xxxxxxxxxx>
> Cc: s.hauer@xxxxxxxxxxxxxx; kernel@xxxxxxxxxxxxxx; Fabio Estevam
> <fabio.estevam@xxxxxxx>; robh+dt@xxxxxxxxxx; mark.rutland@xxxxxxx;
> linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx;
> linux-kernel@xxxxxxxxxxxxxxx; dl-linux-imx <linux-imx@xxxxxxx>
> Subject: Re: [PATCH] ARM: dts: imx7d: add missing OPP property for cpu0
> 
> On Wed, Jul 18, 2018 at 02:54:49PM +0800, Anson Huang wrote:
> > Commit b97872d4eb22 ("ARM: dts: imx: Add missing OPP properties for
> > CPUs") added "operating-points" property for all CPUs, but missed
> > i.MX7D's cpu0, this patch adds it.
> >
> > Fixes: b97872d4eb22 ("ARM: dts: imx: Add missing OPP properties for
> > CPUs")
> > Signed-off-by: Anson Huang <Anson.Huang@xxxxxxx>
> 
> In general, when you send a patch fixing a commit, you should have the author
> of that commit copied.  I added Viresh here.

Thanks, I missed it.

> 
> It looks like a wrong fix to me.  It seems that commit b97872d4eb22 shouldn't
> change imx7d.dtsi at all.  So the correct fix would be reverting the change on
> imx7d.dtsi, @Viresh?

Agreed, I think the arch/arm/boot/dts/imx7d.dtsi should NOT be changed, as it already
had operating-points-v2 on both CPUs, I sent out another new patch with correct fix,
please review it.

Thanks.

Anson.


> 
> Shawn
> 
> > ---
> >  arch/arm/boot/dts/imx7d.dtsi | 5 +++++
> >  1 file changed, 5 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/imx7d.dtsi
> > b/arch/arm/boot/dts/imx7d.dtsi index 9a772fc..30a1a73 100644
> > --- a/arch/arm/boot/dts/imx7d.dtsi
> > +++ b/arch/arm/boot/dts/imx7d.dtsi
> > @@ -9,6 +9,11 @@
> >  / {
> >  	cpus {
> >  		cpu0: cpu@0 {
> > +			operating-points = <
> > +				/* KHz	uV */
> > +				996000	1075000
> > +				792000	975000
> > +			>;
> >  			clock-frequency = <996000000>;
> >  			operating-points-v2 = <&cpu0_opp_table>;
> >  			#cooling-cells = <2>;
> > --
> > 2.7.4
> >